Not finished session marked as 100% finished


Advanced search

Message boards : Website : Not finished session marked as 100% finished

Author Message
elias023
Send message
Joined: 17 Jan 17
Posts: 7
Credit: 804
RAC: 0
Message 15042 - Posted: 25 Jan 2017, 9:36:26 UTC

Under 'Server status', session 3314 was marked as 100% ready even though it was only 99.99131944444444% ready (11519/11520).
Shouldn't it be marked as 99.99% ready?


Profile DoctorNow
Project donor
Avatar
Send message
Joined: 11 Apr 05
Posts: 392
Credit: 2,167,416
RAC: 108
Message 15046 - Posted: 25 Jan 2017, 12:30:03 UTC

The percentage algorithm probably rounds that up already, who knows... ;-)
____________
Life is Science, and Science rules. To the universe and beyond
Proud member of BOINC@Heidelberg
My BOINC-Stats

elias023
Send message
Joined: 17 Jan 17
Posts: 7
Credit: 804
RAC: 0
Message 15049 - Posted: 25 Jan 2017, 18:12:23 UTC - in response to Message 15046.

The percentage algorithm probably rounds that up already, who knows... ;-)


Yeah, it certainly does.
Found this on line 27 in status.php:
$out.= "<td class=\"progress\"><a href=\"session_workunits.php?id=".$session->getID()."\">".showProgressBar($completedPartsFraction, $runningPartsFraction)."</a><div class=\"progresscounter\">".round($completedPartsFraction*100.0,1)."%</div></td>";


Perhaps .round($completedPartsFraction*100.0,1) is what gives the false 100%.
I suggest the code says: If round(...) == 100 AND $completedParts != $totalParts THEN .print($completedPartsFraction*100)

Will some developer have a look at this, please?

Profile Janus
Volunteer moderator
Project administrator
Avatar
Send message
Joined: 16 Jun 04
Posts: 4461
Credit: 2,094,806
RAC: 0
Message 15050 - Posted: 25 Jan 2017, 19:06:14 UTC
Last modified: 25 Jan 2017, 19:32:33 UTC

That is clearly some unacceptable math going on right there. The responsible programmer has been sent to a correctional facility and the problem has been fixed.

elias023
Send message
Joined: 17 Jan 17
Posts: 7
Credit: 804
RAC: 0
Message 15051 - Posted: 26 Jan 2017, 8:57:24 UTC - in response to Message 15050.

That is clearly some unacceptable math going on right there. The responsible programmer has been sent to a correctional facility and the problem has been fixed.


Thanks a lot for the info!


Post to thread

Message boards : Website : Not finished session marked as 100% finished